[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <14835803c03d47bebec4537e985180fc@SC-EXCH04.marvell.com>
Date: Thu, 5 May 2016 15:34:53 +0000
From: Amitkumar Karwar <akarwar@...vell.com>
To: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
CC: "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Ganapathi Bhat <gbhat@...vell.com>
Subject: RE: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download
for Marvell
Hi Alan,
> From: One Thousand Gnomes [mailto:gnomes@...rguk.ukuu.org.uk]
> Sent: Thursday, May 05, 2016 8:53 PM
> To: Amitkumar Karwar
> Cc: linux-bluetooth@...r.kernel.org; linux-kernel@...r.kernel.org;
> Ganapathi Bhat
> Subject: Re: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware
> download for Marvell
>
> > +/* Send ACK/NAK to the device */
> > +static void mrvl_send_ack(struct hci_uart *hu, unsigned char ack) {
> > + struct tty_struct *tty = hu->tty;
> > +
> > + tty->ops->write(tty, &ack, sizeof(ack)); }
>
> You don't know if the device has a write method, and it should be
> locked.
> This should go via your ldisc not directly.
>
Thanks for review. We will take care of this.
Regards,
Amitkumar
Powered by blists - more mailing lists