linux-kernel - Re: [PATCH] Fix CONFIG_PM_OPP without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 May 2016 08:31:09 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Eric Engestrom <eric.engestrom@...tec.com>
Cc:	linux-kernel@...r.kernel.org,
	Rufus Hamade <rufus.hamade@...tec.com>,
	Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH] Fix CONFIG_PM_OPP without CONFIG_OF build failure

On 03-05-16, 14:14, Eric Engestrom wrote:
> diff --git a/drivers/base/power/opp/cpu.c b/drivers/base/power/opp/cpu.c
> index ba2bdbd..8aae170 100644
> --- a/drivers/base/power/opp/cpu.c
> +++ b/drivers/base/power/opp/cpu.c
> @@ -119,6 +119,7 @@ void dev_pm_opp_free_cpufreq_table(struct device *dev,
>  EXPORT_SYMBOL_GPL(dev_pm_opp_free_cpufreq_table);
>  #endif	/* CONFIG_CPU_FREQ */
>  
> +#ifdef CONFIG_OF
>  /* Required only for V1 bindings, as v2 can manage it from DT itself */
>  int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask)
>  {
> @@ -160,7 +161,6 @@ int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask)
>  }
>  EXPORT_SYMBOL_GPL(dev_pm_opp_set_sharing_cpus);
>  
> -#ifdef CONFIG_OF
>  void dev_pm_opp_of_cpumask_remove_table(cpumask_var_t cpumask)
>  {
>  	struct device *cpu_dev;

This change was incorrect as this API can be used for non-OF case.
Some things have already changed, can you please rebase on linux-next
and resend this patch?

-- 
viresh