linux-kernel - Re: [PATCH] of: fix device compatibility scoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 May 2016 14:47:18 -0500
From:	Rob Herring <robh+dt@...nel.org>
To:	Reza Arbab <arbab@...ux.vnet.ibm.com>
Cc:	Frank Rowand <frowand.list@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Kevin Hao <haokexin@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: fix device compatibility scoring

On Thu, May 5, 2016 at 1:30 PM, Reza Arbab <arbab@...ux.vnet.ibm.com> wrote:
> If a constraint given to __of_device_is_compatible() does not
> match, we should just move to the next constraint without adding
> to the compatibility score. Instead, the function immediately
> returns 0.
>
> Do not return from __of_device_is_compatible() until a complete
> score has been calculated.

This matching is very sensitive to changes. Can you please describe
what conditions don't work for you and add a test case for that
condition to the unit test.

Rob