[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 5 May 2016 15:55:54 -0700
From: Doug Anderson <dianders@...omium.org>
To: David Wu <david.wu@...k-chips.com>
Cc: Heiko Stübner <heiko@...ech.de>,
Wolfram Sang <wsa@...-dreams.de>,
Rob Herring <robh+dt@...nel.org>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Brian Norris <briannorris@...gle.com>,
David Riley <davidriley@...gle.com>,
Tao Huang <huangtao@...k-chips.com>,
Lin Huang <hl@...k-chips.com>, Jianqun Xu <xjq@...k-chips.com>,
Chris <zyw@...k-chips.com>, Eddie Cai <cf@...k-chips.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 3/9] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()
David,
On Wed, May 4, 2016 at 7:13 AM, David Wu <david.wu@...k-chips.com> wrote:
> Call rk3x_i2c_setup() before rk3x_i2c_start()
> and the last thing in setup was to clean the IPD,
> so no reason to do it at the beginning of start.
>
> Signed-off-by: David Wu <david.wu@...k-chips.com>
> ---
> Change in v7:
> - none
>
> drivers/i2c/busses/i2c-rk3x.c | 1 -
> 1 file changed, 1 deletion(-)
Looks great. Thanks for splitting this out from other patches--makes
it much more obvious what's happening! :)
IMHO this can be applied any time independent of any earlier patches.
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists