[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 5 May 2016 15:57:39 -0700
From: Doug Anderson <dianders@...omium.org>
To: David Wu <david.wu@...k-chips.com>
Cc: Heiko Stübner <heiko@...ech.de>,
Wolfram Sang <wsa@...-dreams.de>,
Rob Herring <robh+dt@...nel.org>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Brian Norris <briannorris@...gle.com>,
David Riley <davidriley@...gle.com>,
Tao Huang <huangtao@...k-chips.com>,
Lin Huang <hl@...k-chips.com>, Jianqun Xu <xjq@...k-chips.com>,
Chris <zyw@...k-chips.com>, Eddie Cai <cf@...k-chips.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 5/9] i2c: rk3x: Change SoC data to not use array
Hi,
On Wed, May 4, 2016 at 7:33 AM, David Wu <david.wu@...k-chips.com> wrote:
> Signed-off-by: David Wu <david.wu@...k-chips.com>
nit: $SUBJECT should probably mention that this also constifies the SoC data.
Again, needs description, like maybe:
Specifying the i2c SoC data in an array provides very little benefit and
gets unwieldly / confusing as the array grows since the next bit of code
needs to refer to elements in the array by their raw integral index.
Let's just create a single 'static const' structure for each SoC so that
we can refer to these structures by ID.
IMHO this can be applied any time independent of any earlier patches.
Suggested-by: Douglas Anderson <dianders@...omium.org>
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists