linux-kernel - Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <572C307F.7090102@samsung.com>
Date:	Fri, 06 May 2016 07:49:51 +0200
From:	Krzysztof Opasiak <k.opasiak@...sung.com>
To:	"Du, Changbin" <changbin.du@...el.com>,
	"balbi@...nel.org" <balbi@...nel.org>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"corbet@....net" <corbet@....net>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Du, Changbin" <changbin.du@...il.com>,
	"Du@...r.kernel.org" <Du@...r.kernel.org>
Subject: Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as
 binding to *any* UDC



On 05/06/2016 04:46 AM, Du, Changbin wrote:
(...)
>> Well, I'm not sure if any configfs interface has been proposed as easy
>> to use from cmd line. I think they all has been proposed as  *usable*
>> from cmd line but not necessarily *easy to use*.
>>
>> That's why most of configfs clients has some support in userspace. For
>> example for target there is a taget-cli and for usb gadget we have
>> libusbg/libusbgx.
>>
> Glade to know this tool, it is much more easy to use than interact with sysfs.
> I'd like use it. Just see you are the main contributor of this project. :)
> 

That's true;) personally I would recommend you using libusbgx[1] instead
of libusbg[2] as it is far more recent and usable (292 commits vs 128;) )

(...)

>>
>> What do you mean pseudo 'busy'? If we do:
>>
>> echo <udc-name> > UDC
>>
> Sorry, please ignore this. I find if no UDC available, the config will be queued
> to a list, and will bind it when a UDC module install. So it is really busy.
> 
>> then gadget should be really bound to some udc and potentially really busy.
>>
>>> In a word, this patch is just an improvement, not to fix any issues or
>>> add new function.
>>
>> So it doesn't add any new functionality and breaks existing user space
>> tools.
>>

Yes, currently it's true but it's a bug which I have fixed yesterday[3]

Footnotes:
1 - https://github.com/libusbgx/libusbgx
2 - https://github.com/libusbg/libusbg
3 - http://marc.info/?l=linux-usb&m=146243801207458&w=2

Cheers,
-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics