linux-kernel - Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VctvfF6pzmw05WP8aYJx9kttbCJYEEFkUNjDszRC=Oujg@mail.gmail.com>
Date:	Fri, 6 May 2016 14:38:44 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Maarten Brock <m.brock@...mierlo.com>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"Bryan O'Donoghue" <pure.logic@...us-software.ie>,
	Peter Hurley <peter@...leysoftware.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	Vinod Koul <vinod.koul@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	dmaengine <dmaengine@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Puustinen, Ismo" <ismo.puustinen@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

On Fri, May 6, 2016 at 2:20 PM, Maarten Brock <m.brock@...mierlo.com> wrote:
>> > >
>> > > +       bool                    polarity;
>> > So this variable is not very intuitively named.
>>
>> There is a help above. This is a property of the Synopsys DesignWare DMA
>> engine. Anyone familiar with datasheet easily understands this.
>>
>> >
>> > You end up setting somepointer->polarity = true; in a later patch.
>> >
>> > Since you're respining a V4 I'd suggest a name that describes a little
>> > bit better than polarity. Setting polarity = true is a little bit
>> > liked being asked "you you like ice-cream or apple pie" and then
>> > saying "yes please".
>>
>> It's about handshake interface polarity, so, what about hs_polarity?
>
> So it means: handshake has polarity (true) or handshake has no polarity
> (omnidirectional?) (false), right?

It means that handshake polarity _signal_ is inverted (true) or
default (false) in terms of hardware gates.

-- 
With Best Regards,
Andy Shevchenko