linux-kernel - Re: [PATCH 0/8] Add support for remote unwind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160506115815.GW11069@kernel.org>
Date:	Fri, 6 May 2016 08:58:15 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	He Kuang <hekuang@...wei.com>, Jiri Olsa <jolsa@...nel.org>
Cc:	peterz@...radead.org, Ingo Molnar <mingo@...nel.org>,
	alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
	wangnan0@...wei.com, jpoimboe@...hat.com, ak@...ux.intel.com,
	eranian@...gle.com, namhyung@...nel.org, adrian.hunter@...el.com,
	sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com,
	tumanova@...ux.vnet.ibm.com, kan.liang@...el.com,
	penberg@...nel.org, dsahern@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] Add support for remote unwind

Em Fri, May 06, 2016 at 08:59:06AM +0000, He Kuang escreveu:
> Currently, perf script uses host unwind methods to parse perf.data
> callchain info regardless of the target architecture. So we get wrong
> result and no promotion when do remote unwind on other
> platforms/machines.

Thanks for working on this, being able to record on one machine and do
analysis in another, of a different hw architectures is indeed a goal
for the perf tools!

Jiri, if you could please take a look, that would be really great!

- Arnaldo
 
> This patch set adds build tests for the supported platforms for remote
> unwinding, and checks the map elf info for each thread, use remote
> unwind methods instead.
> 
> Only x86 and aarch64 is added in this patch set to show the work flow,
> other platforms can be added easily.
> 
> We can see the right result for unwind infos on different machines,
> for example: we record perf.data on i686 qemu with '-g' option and
> parse it on x86_64 machine.
> 
> before this patchset:
> 
>   hello  1071 [000]   417.567832: probe:sys_close: (c1169d60)
>                   c1169d61 sys_close ([kernel.kallsyms])
>                   c189c0d7 sysenter_past_esp ([kernel.kallsyms])
>                   b77c8ba9 [unknown] ([vdso32])
>   
> after:
> 
>   hello  1071 [000]   417.567832: probe:sys_close: (c1169d60)
>                   c1169d61 sys_close ([kernel.kallsyms])
>                   c189c0d7 sysenter_past_esp ([kernel.kallsyms])
>                   b77c8ba9 [unknown] ([vdso32])
>                   b76e51cc close (/lib/libc-2.22.so)
>                    804842e fib (/tmp/hello)
>                    804849d main (/tmp/hello)
>                   b762546e __libc_start_main (/lib/libc-2.22.so)
>                    8048341 _start (/tmp/hello)
> 
> Thanks, discussion welcomed.
> 
> He Kuang (8):
>   perf tools: Omit DWARF judgement when recording dwarf callchain
>   perf script: Add options for custom vdso name
>   perf build: Add build-test for libunwind cross-platforms support
>   perf build: Add build-test for debug-frame on arm/arm64
>   perf tools: Promote proper messages for cross-platform unwind
>   perf callchain: Add support for cross-platform unwind
>   perf callchain: Support x86 target platform
>   perf callchain: Support aarch64 cross-platform
> 
>  tools/build/Makefile.feature                       | 11 +++-
>  tools/build/feature/Makefile                       | 26 +++++++-
>  tools/build/feature/test-libunwind-aarch64.c       | 26 ++++++++
>  tools/build/feature/test-libunwind-arm.c           | 27 +++++++++
>  .../feature/test-libunwind-debug-frame-aarch64.c   | 16 +++++
>  .../build/feature/test-libunwind-debug-frame-arm.c | 16 +++++
>  tools/build/feature/test-libunwind-debug-frame.c   | 16 -----
>  tools/build/feature/test-libunwind-x86.c           | 27 +++++++++
>  tools/build/feature/test-libunwind-x86_64.c        | 27 +++++++++
>  .../arch/arm64/include/libunwind/libunwind-arch.h  | 18 ++++++
>  tools/perf/arch/arm64/util/unwind-libunwind.c      |  5 +-
>  .../arch/x86/include/libunwind/libunwind-arch.h    | 18 ++++++
>  tools/perf/arch/x86/util/unwind-libunwind.c        | 42 +++++++++++++
>  tools/perf/builtin-script.c                        |  2 +
>  tools/perf/config/Makefile                         | 35 ++++++++++-
>  tools/perf/util/Build                              | 13 +++-
>  tools/perf/util/dso.c                              |  7 +++
>  tools/perf/util/dso.h                              |  1 +
>  tools/perf/util/symbol-elf.c                       | 16 +++++
>  tools/perf/util/symbol.c                           | 50 ++++++++++++++++
>  tools/perf/util/symbol.h                           |  3 +
>  tools/perf/util/thread.c                           | 70 ++++++++++++++++++++--
>  tools/perf/util/thread.h                           | 14 ++++-
>  tools/perf/util/unwind-libunwind.c                 | 50 +++++++++++++---
>  tools/perf/util/unwind-libunwind_common.c          | 60 +++++++++++++++++++
>  tools/perf/util/unwind.h                           | 30 ++++++++++
>  tools/perf/util/util.c                             |  2 -
>  27 files changed, 589 insertions(+), 39 deletions(-)
>  create mode 100644 tools/build/feature/test-libunwind-aarch64.c
>  create mode 100644 tools/build/feature/test-libunwind-arm.c
>  create mode 100644 tools/build/feature/test-libunwind-debug-frame-aarch64.c
>  create mode 100644 tools/build/feature/test-libunwind-debug-frame-arm.c
>  delete mode 100644 tools/build/feature/test-libunwind-debug-frame.c
>  create mode 100644 tools/build/feature/test-libunwind-x86.c
>  create mode 100644 tools/build/feature/test-libunwind-x86_64.c
>  create mode 100644 tools/perf/arch/arm64/include/libunwind/libunwind-arch.h
>  create mode 100644 tools/perf/arch/x86/include/libunwind/libunwind-arch.h
>  create mode 100644 tools/perf/util/unwind-libunwind_common.c
> 
> -- 
> 1.8.5.2