lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 May 2016 15:15:32 +0100 From: Jon Hunter <jonathanh@...dia.com> To: Laxman Dewangan <ldewangan@...dia.com>, <thierry.reding@...il.com>, <airlied@...ux.ie>, <swarren@...dotorg.org>, <gnurou@...il.com> CC: <dri-devel@...ts.freedesktop.org>, <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH V4 2/3] soc/tegra: pmc: Correct type of variable for tegra_pmc_readl() On 06/05/16 11:45, Laxman Dewangan wrote: > The function tegra_pmc_readl() returns the u32 type data and hence > change the data type of variable where this data is stored to u32 > type. > > Signed-off-by: Laxman Dewangan <ldewangan@...dia.com> > > --- > Changes from V1: > -This is new in series as per discussion on V1 series to use u32 for > tegra_pmc_readl. > > Changes from V2: > - Make unsigned long to u32 for some missed variable from V1. > > Changes from V3: > - Revert back the value to ulong where time calcualtion is done. > --- > drivers/soc/tegra/pmc.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index 2c3f1f9..09c2b97 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -875,10 +875,10 @@ static int tegra_io_rail_prepare(unsigned int id, unsigned long *request, > return 0; > } > > -static int tegra_io_rail_poll(unsigned long offset, unsigned long mask, > - unsigned long val, unsigned long timeout) > +static int tegra_io_rail_poll(unsigned long offset, u32 mask, > + u32 val, unsigned long timeout) > { > - unsigned long value; > + u32 value; > > timeout = jiffies + msecs_to_jiffies(timeout); > > @@ -900,8 +900,9 @@ static void tegra_io_rail_unprepare(void) > > int tegra_io_rail_power_on(unsigned int id) > { > - unsigned long request, status, value; > - unsigned int bit, mask; > + unsigned long request, status; > + unsigned int bit; > + u32 value, mask; > int err; > > mutex_lock(&pmc->powergates_lock); > @@ -935,8 +936,9 @@ EXPORT_SYMBOL(tegra_io_rail_power_on); > > int tegra_io_rail_power_off(unsigned int id) > { > - unsigned long request, status, value; > - unsigned int bit, mask; > + unsigned long request, status; > + unsigned int bit; > + u32 value, mask; > int err; > > mutex_lock(&pmc->powergates_lock); > Reviewed-by: Jon Hunter <jonathanh@...dia.com> Cheers Jon
Powered by blists - more mailing lists