linux-kernel - Re: [PATCH 1/6] statx: Add a system call to make enhanced file info available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160506013905.GQ18496@dastard>
Date:	Fri, 6 May 2016 11:39:05 +1000
From:	Dave Chinner <david@...morbit.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Jeff Layton <jlayton@...chiereds.net>,
	NeilBrown <nfbrown@...ell.com>, linux-fsdevel@...r.kernel.org,
	linux-afs@...r.kernel.org, linux-nfs@...r.kernel.org,
	samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/6] statx: Add a system call to make enhanced file info
 available

On Thu, May 05, 2016 at 09:04:09PM +0100, David Howells wrote:
> Jeff Layton <jlayton@...chiereds.net> wrote:
> 
> > I don't see a real attack vector here either, but OTOH is there a
> > potential user of this at the moment?
> 
> I'm not sure.  BSD stat has an st_gen, so it's possible something out there
> will use it if it exists.

Oh, I know of several userspace applications that use the inode
generation number for some purpose. However, all of them are so
tightly tied to the XFS internal structure, implementation and the
XFS specific bulkstat interface that they cannot be considered
generic applications.

> > An earlier chunk of the patch description says:
> > 
> > (7) Inode generation number: Useful for FUSE and userspace NFS servers
> >      [Bernd Schubert].  This was asked for but later deemed unnecessary
> >      with the open-by-handle capability available
> > 
> > ...the last bit seems to indicate that we don't really need this
> > anyway, as most userland servers now work with filehandles from the
> > kernel.
> > 
> > Maybe leave it out for now? It can always be added later.
> 
> Yeah...  probably a good idea.

Fine by me.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com