linux-kernel - Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <572C034C.1090805@nvidia.com>
Date:	Fri, 6 May 2016 10:37:00 +0800
From:	Jim Lin <jilin@...dia.com>
To:	Felipe Balbi <balbi@...nel.org>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed

On 2016年05月04日 18:37, Felipe Balbi wrote:
> * PGP Signed by an unknown key
>
>
> Hi,
>
> Jim Lin <jilin@...dia.com> writes:
>
> <snip>
>
>>>> In f_fs.c
>>>> "
>>>> static int __ffs_data_do_os_desc(enum ffs_os_desc_type type,
>>>>                     struct usb_os_desc_header *h, void *data,
>>>>                     unsigned len, void *priv)
>>>> {
>>>>        struct ffs_data *ffs = priv;
>>>>        u8 length;
>>>>
>>>>        ENTER();
>>>>
>>>>        switch (type) {
>>>>        case FFS_OS_DESC_EXT_COMPAT: {
>>>>            struct usb_ext_compat_desc *d = data;
>>>>            int i;
>>>>
>>>>            if (len < sizeof(*d) ||
>>>>                d->bFirstInterfaceNumber >= ffs->interfaces_count ||
>>>>                d->Reserved1)
>>>>                return -EINVAL;
>>>> "
>>> that's fine, but this is only failing because something else is
>>> returning the wrong set of descriptors (SS vs HS). That's the bug we
>>> want to fix, not work around it.
>>>
>> Thanks.
> you're welcome, but to fix that bug we need more information. Why is
> composite.c using the wrong set of descriptors ? What is your setup ?
>
> Are you using an in-kernel gadget ? which one ? Using configfs or legacy
> gadgets ? gadgetfs ? f_fs ? How to trigger this ? Can you provide
> instructions and (in case of gadgetfs/ffs) code to create a gadget that
> hits this problem ?
>
For some reason I have to put this patch on hold.

Thanks,
--nvpublic