[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160507191038.GH19977@krava>
Date: Sat, 7 May 2016 21:10:38 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Andi Kleen <andi@...stfloor.org>
Cc: acme@...nel.org, peterz@...radead.org, jolsa@...nel.org,
linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for
integer scales
On Thu, May 05, 2016 at 04:04:03PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
>
> When the scaling factor is a full integer don't display fractional
> digits. This avoids unnecessary .00 output for topdown metrics
> with scale factors.
>
> v2: Remove redundant check.
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
> tools/perf/builtin-stat.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 1f19f2f999c8..b407a11c6e22 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -66,6 +66,7 @@
> #include <stdlib.h>
> #include <sys/prctl.h>
> #include <locale.h>
> +#include <math.h>
>
> #define DEFAULT_SEPARATOR " "
> #define CNTR_NOT_SUPPORTED "<not supported>"
> @@ -978,12 +979,12 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
> const char *fmt;
>
> if (csv_output) {
> - fmt = sc != 1.0 ? "%.2f%s" : "%.0f%s";
> + fmt = floor(sc) != sc ? "%.2f%s" : "%.0f%s";
> } else {
> if (big_num)
> - fmt = sc != 1.0 ? "%'18.2f%s" : "%'18.0f%s";
> + fmt = floor(sc) != sc ? "%'18.2f%s" : "%'18.0f%s";
> else
> - fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";
> + fmt = floor(sc) != sc ? "%18.2f%s" : "%18.0f%s";
how about the rest of the code? we display % also in print_running
and print_noise_pct functions and maybe some place else
would be nice having unified output for %
thanks,
jirka
> }
>
> aggr_printout(evsel, id, nr);
> --
> 2.5.5
>
Powered by blists - more mailing lists