linux-kernel - Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160507192425.GA13997@two.firstfloor.org>
Date:	Sat, 7 May 2016 12:24:25 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
	peterz@...radead.org, jolsa@...nel.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for
 integer scales

> >  	if (csv_output) {
> > -		fmt = sc != 1.0 ?  "%.2f%s" : "%.0f%s";
> > +		fmt = floor(sc) != sc ?  "%.2f%s" : "%.0f%s";
> >  	} else {
> >  		if (big_num)
> > -			fmt = sc != 1.0 ? "%'18.2f%s" : "%'18.0f%s";
> > +			fmt = floor(sc) != sc ? "%'18.2f%s" : "%'18.0f%s";
> >  		else
> > -			fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";
> > +			fmt = floor(sc) != sc ? "%18.2f%s" : "%18.0f%s";
> 
> how about the rest of the code? we display % also in print_running
> and print_noise_pct functions and maybe some place else

For those it doesn't matter. In fact it's probably better there
to always show the fractions.

It is just confusing for metrics.

-Andi