linux-kernel - Re: [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <572D5182.9090808@roeck-us.net>
Date:	Fri, 6 May 2016 19:22:58 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Dan Williams <dan.j.williams@...el.com>, linux-nvdimm@...ts.01.org
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure

On 05/06/2016 10:26 AM, Dan Williams wrote:
> I had relied on the kbuild robot for cross build coverage, however it
> only builds alpha_defconfig.  Switch from HPAGE_SIZE to PMD_SIZE, which
> is more widely defined.
>
> Fixes: 658922e57b84 ("libnvdimm, pfn: fix memmap reservation sizing")
> Cc: <stable@...r.kernel.org>
> Reported-by: Guenter Roeck <guenter@...ck-us.net>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Passes at least all my tests.

Tested-by: Guenter Roeck <linux@...ck-us.net>

Nitpick below.

> ---
>   drivers/nvdimm/pmem.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 5101f3ab4f29..e5a8bf032ec9 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -404,7 +404,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn)
>   		 * vmemmap_populate_hugepages() allocates the memmap array in
>   		 * HPAGE_SIZE chunks.
PMD_SIZE

>   		 */
> -		memmap_size = ALIGN(64 * npfns, HPAGE_SIZE);
> +		memmap_size = ALIGN(64 * npfns, PMD_SIZE);
>   		offset = ALIGN(start + SZ_8K + memmap_size, nd_pfn->align)
>   			- start;
>   	} else if (nd_pfn->mode == PFN_MODE_RAM)
>
>