linux-kernel - Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160508024627.GA13955@kroah.com>
Date:	Sun, 8 May 2016 04:46:27 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Thimo Braker <thibmorozier@...il.com>
Cc:	devel@...verdev.osuosl.org, arve@...roid.com,
	linux-kernel@...r.kernel.org, riandrews@...roid.com,
	sumit.semwal@...aro.org
Subject: Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef

On Sat, May 07, 2016 at 03:22:03PM -0500, Thimo Braker wrote:
> Fixes a checkpatch.pl warning about 'do not add new typedefs'
> 
> Signed-off-by: Thimo Braker <thibmorozier@...il.com>
> ---
>  drivers/staging/android/uapi/ion.h | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 0a8e40f..77a46f0 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -20,8 +20,6 @@
>  #include <linux/ioctl.h>
>  #include <linux/types.h>
>  
> -typedef int ion_user_handle_t;
> -

You just broke userspace :(

Sorry, you can't do this, be careful when touching files that cross the
user/kernel boundry (hint, they have uapi in the path), you have to know
exactly what you are doing when you do that.

thanks,

greg k-h