linux-kernel - Re: [PATCH] sched: fix the calculation of __sched_period in sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160509070502.GA3430@twins.programming.kicks-ass.net>
Date:	Mon, 9 May 2016 09:05:02 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Zhou Chengming <zhouchengming1@...wei.com>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org,
	guohanjun@...wei.com, huawei.libin@...wei.com
Subject: Re: [PATCH] sched: fix the calculation of __sched_period in
 sched_slice()

On Mon, May 09, 2016 at 10:45:57AM +0800, Zhou Chengming wrote:
> When we get the sched_slice of a sched_entity, we use cfs_rq->nr_running
> to calculate the whole __sched_period. But cfs_rq->nr_running is the
> number of sched_entity in that cfs_rq, rq->nr_running is the number
> of all the tasks that are not throttled. So we should use the
> rq->nr_running to calculate the whole __sched_period value.

No, this was very much on purpose.