linux-kernel - Re: [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160509073204.GI29353@suse.cz>
Date:	Mon, 9 May 2016 09:32:04 +0200
From:	David Sterba <dsterba@...e.cz>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	gregkh@...uxfoundation.org, Jiri Kosina <jikos@...nel.org>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL

On Mon, May 09, 2016 at 09:11:53AM +0200, Jiri Slaby wrote:
> In ipwireless_get_serial_info, struct serial_struct is memset to 0 and
> then some members set to 0 explicitly.
> 
> Remove the latter as it is obviously superfluous.
> 
> And remove the retinfo check against NULL. copy_to_user will take care
> of that.
> 
> Part of hub6 cleanup series.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: David Sterba <dsterba@...e.com>

Acked-by: David Sterba <dsterba@...e.com>