linux-kernel - Re: [PATCH v6 0/9] mfd: max8997: Add regmap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160509073549.GC8324@dell>
Date:	Mon, 9 May 2016 08:35:49 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Kukjin Kim <kgene@...nel.org>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-pm@...r.kernel.org, rtc-linux@...glegroups.com,
	r.baldyga@...kerion.com,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v6 0/9] mfd: max8997: Add regmap support

On Fri, 06 May 2016, Krzysztof Kozlowski wrote:
> This is a rebase and extension of old Robert Baldyga's work. [0]
> 
> Robert no longer works in Samsung.
> 
> From the original cover letter:
> "This patchset modifies max8997 driver and associated function drivers to use
> register maps instead of operating directly on i2c bus. This change allowed
> to simplify irq handling, and to move some initializations to individual
> function drivers. Hence now when some functions are not enabled, their i2c
> clients, regmaps and irqs are not registered."
> 
> 
> My changes (since Robert's v5)
> ==============================
> 1. Rebase on v4.6-rc6.
> 2. Collect more acks.
> 3. Add few fixes:
>    a. Haptic fix from Marek,
>    b. Extcon and RTC fix from me,
>    c. DTS fixes from Marek.
> 
> DTS changes are independent but rest of them (extcon/input/MFD) rely
> on each other.
> 
> One way of merging would be to pick everything (except DTS) through
> one tree. Or use tags.

I'd be happy to take the set, once you have collected all Acks.

> Best regards,
> Krzysztof
> 
> [0] http://lkml.iu.edu/hypermail//linux/kernel/1411.1/03152.html
> 
> 
> Krzysztof Kozlowski (3):
>   extcon: max8997: Fix handling error code of regmap_irq_get_virq()
>   rtc: max8997: Check for ERRNO of regmap_irq_get_virq()
>   extcon: max8997: Fix inconsistent indenting
> 
> Marek Szyprowski (3):
>   input: max8997-haptic: Fix NULL pointer dereference
>   ARM: dts: exynos: Fix regulator name to avoid forbidden character on
>     exynos4210-trats
>   ARM: dts: exynos: Add interrupt line to MAX8997 PMIC on
>     exynos4210-trats
> 
> Robert Baldyga (3):
>   mfd: max8997: Use regmap to access registers
>   mfd: max8997: handle IRQs using regmap
>   mfd: max8997: Change irq names to upper case
> 
>  arch/arm/boot/dts/exynos4210-trats.dts |   4 +-
>  drivers/extcon/extcon-max8997.c        |  72 ++++---
>  drivers/input/misc/max8997_haptic.c    |  40 ++--
>  drivers/leds/leds-max8997.c            |  13 +-
>  drivers/mfd/Kconfig                    |   3 +-
>  drivers/mfd/Makefile                   |   2 +-
>  drivers/mfd/max8997-irq.c              | 383 ---------------------------------
>  drivers/mfd/max8997.c                  | 245 ++++++++++++++-------
>  drivers/power/max8997_charger.c        |  33 +--
>  drivers/regulator/max8997.c            |  87 ++++----
>  drivers/rtc/rtc-max8997.c              |  60 +++---
>  include/linux/mfd/max8997-private.h    |  82 +++++--
>  12 files changed, 392 insertions(+), 632 deletions(-)
>  delete mode 100644 drivers/mfd/max8997-irq.c
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog