linux-kernel - Re: [PATCH 1/1] usb: net2272: avoid shifting 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 May 2016 11:09:45 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Heinrich Schuchardt <xypron.glpk@....de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
	John Youn <John.Youn@...opsys.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>,
	Robert Baldyga <r.baldyga@...sung.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Heinrich Schuchardt <xypron.glpk@....de>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH 1/1] usb: net2272: avoid shifting 0


Heinrich Schuchardt <xypron.glpk@....de> writes:
> Remove redundant code.
> Or'ing with a shifted value of zero is a NOP.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>

it sure is and the compiler is getting rid of those. They are there as
means of documentation only ;-)

I really have no strong feelings about this patch, so I'll let the other
folks who have been hacking on this to decide.

-- 
balbi