linux-kernel - Re: [PATCH] i2c: designware: do not disable adapter after transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 May 2016 10:50:20 +0200
From:	Christian Ruppert <christian.ruppert@...tech.com>
To:	Lucas De Marchi <lucas.de.marchi@...il.com>
Cc:	Lucas De Marchi <lucas.demarchi@...el.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"wsa@...-dreams.de" <wsa@...-dreams.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
	"jarkko.nikula@...ux.intel.com" <jarkko.nikula@...ux.intel.com>
Subject: Re: [PATCH] i2c: designware: do not disable adapter after transfer

Dear Lucas,

On 04.05.2016 16:38, Lucas De Marchi wrote:
> Hi Christian,
> 
> On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert
> <christian.ruppert@...tech.com> wrote:
>> Dear Lucas,
>>
>> On 22.04.2016 17:19, Lucas De Marchi wrote:
>>> CC'ing Christian.
>>>
>>> On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi
>>> <lucas.demarchi@...el.com> wrote:
> [...]
>> Bad  news: Not all transfers seem to take place as they should.
>>            I don't have the time for a deep analysis but a few quick
>>            experiments seem to indicate that the adapter needs to be
>>            disabled while updating TAR to a value different from the
>>            previous one. Disabling the adapter does not seem to be
>>            required if TAR doesn't change from one transfer to the next.
>>            I don't know if there are any conditions under which we can
>>            leave the adapter enabled while changing TAR but at least in
>>            some cases it seems to work.
> 
> :(
> 
> This is unfortunate. If the bus is shared for 2 slave devices we will
> get the slow down back. I wonder if there's a HW version or something
> like that in the registers which can be used to add quirks to tweak the
> behavior.  I'll dig some documentation, but if anyone knows, it'd be
> nice to have it pointed out.

There is such a register (DW_IC_COMP_VERSION) and we used it before for
hold time configuration, see line 374. In my case, the value of the
register is 0x3131372a. We're now just left with the problem to find out
how many (and which) hardware issues there are and in which version they
were fixed exactly...

Greetings,
  Christian