linux-kernel - Re: [PATCH v2 1/1] Staging: android: uapi: ion: Fixes indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160509120805.GA4311@kroah.com>
Date:	Mon, 9 May 2016 14:08:05 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Thimo Braker <thibmorozier@...il.com>
Cc:	labbott@...hat.com, sumit.semwal@...aro.org, arve@...roid.com,
	iandrews@...roid.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] Staging: android: uapi: ion: Fixes indentation

On Sun, May 08, 2016 at 01:41:47PM +0200, Thimo Braker wrote:
> Fixes the indentation before variable names.
> 
> Signed-off-by: Thimo Braker <thibmorozier@...il.com>
> ---
>  drivers/staging/android/uapi/ion.h      | 20 ++++++++++----------
>  drivers/staging/android/uapi/ion_test.h | 10 +++++-----
>  2 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 0a8e40f..6dda8d5 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -91,11 +91,11 @@ enum ion_heap_type {
>   * Provided by userspace as an argument to the ioctl
>   */
>  struct ion_allocation_data {
> -	size_t len;
> -	size_t align;
> -	unsigned int heap_id_mask;
> -	unsigned int flags;
> -	ion_user_handle_t handle;
> +	size_t			len;
> +	size_t			align;
> +	unsigned int		heap_id_mask;
> +	unsigned int		flags;
> +	ion_user_handle_t	handle;

Hm, that's not really a "fix" anywhere.  There's no kernel rule that you
have to align the fields in a structure.

What "tool" told you this was necessary?

So this patch isn't needed, sorry.

thanks,

greg k-h