linux-kernel - Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c4cc9fc-26df-759e-6630-7bab927cf01b@iommu.org>
Date:	Mon, 9 May 2016 20:17:12 +0800
From:	Wan Zongshun <vw@...mu.org>
To:	Joerg Roedel <joro@...tes.org>, Wan Zongshun <vincent.wan@....com>
Cc:	iommu@...ts.linux-foundation.org, mcuos.com@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus
 driver



-------- Original Message --------
> On Thu, Apr 14, 2016 at 09:28:53AM -0400, Wan Zongshun wrote:
>> From: Wan Zongshun <Vincent.Wan@....com>
>>
>> AMD has more drivers will use ACPI to platform bus driver later,
>> all those devices need iommu support, such as eMMC acpi driver.
>>
>> Signed-off-by: Wan Zongshun <Vincent.Wan@....com>
>> ---
>>  drivers/iommu/amd_iommu.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
>> index c430c10..547cdd4 100644
>> --- a/drivers/iommu/amd_iommu.c
>> +++ b/drivers/iommu/amd_iommu.c
>> @@ -21,6 +21,7 @@
>>  #include <linux/pci.h>
>>  #include <linux/acpi.h>
>>  #include <linux/amba/bus.h>
>> +#include <linux/platform_device.h>
>>  #include <linux/pci-ats.h>
>>  #include <linux/bitmap.h>
>>  #include <linux/slab.h>
>> @@ -2980,6 +2981,9 @@ int __init amd_iommu_init_api(void)
>>  	if (err)
>>  		return err;
>>  #endif
>> +	err = bus_set_iommu(&platform_bus_type, &amd_iommu_ops);
>> +	if (err)
>> +		return err;
>
> Is the platform_bus_type always defined or does this code needs to be
> guarded by another ifdef?

Joerg,

Currently, Only New eMMC driver will rely on this sdhci-acpi.c, but I 
could not find a suitable ifdef XXX micro to limit this 
platform_bus_type here like AMBA bus type before.

Do you think this MMC_SDHCI_ACPI is ok?

Vincent.

>
>
>
> 	Joerg
>