linux-kernel - Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160509122452.GA28034@kroah.com>
Date:	Mon, 9 May 2016 14:24:52 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Bruno Carvalho <brunocarvalhofarias@...il.com>
Cc:	ciorneiioana@...il.com, amitoj1606@...il.com,
	s.demeszko@...eless-instruments.com, shraddha.6596@...il.com,
	bhumirks@...il.com, shivanib134@...il.com,
	mahfouz.saif.elyazal@...il.com, tj@...nel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of
 alloc_tty_driver

On Sat, May 07, 2016 at 11:29:14PM -0400, Bruno Carvalho wrote:
> - alloc_tty_driver() is deprecated. So it is replaced by tty_alloc_driver()
> 
> Signed-off-by: Bruno Carvalho <brunocarvalhofarias@...il.com>
> ---
>  drivers/staging/gdm724x/gdm_tty.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..c0888f5 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -306,7 +306,9 @@ int register_lte_tty_driver(void)
>  	int ret;
>  
>  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> -		tty_driver = alloc_tty_driver(GDM_TTY_MINOR);
> +		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> +					      TTY_DRIVER_REAL_RAW |
> +					      TTY_DRIVER_DYNAMIC_DEV);

You just changed the logic here, previously we were passing in 0 for the
flags, now you are setting some to a different value, why?

thanks,

greg k-h