linux-kernel - Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5730825E.5030101@linaro.org>
Date:	Mon, 9 May 2016 13:28:14 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Peng Fan <van.freenix@...il.com>, shawnguo@...nel.org,
	maxime.ripard@...e-electrons.com
Cc:	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock

Thanks for the Ping, I totally missed this thread.

On 20/04/16 18:26, Peng Fan wrote:
> Before access ocotp nvmem area, the clock should be enabled.
> Or, `hexdump nvmem` will hang the system. So, use such flow:
> "
>    1. clock_enable_prepare
>    2. read nvmem ocotp area
>    3. clock_disable_unprepare
> "
>
> Signed-off-by: Peng Fan <van.freenix@...il.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> ---
>
> V2:
>   Follow Fabio's comments, check return value of clk_prepare_enable
>
>   drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++-
>   1 file changed, 15 insertions(+), 1 deletion(-)

Changes to the driver looks good to me,
Only one comment, As the clock property is now made mandatory, you 
should update the dt-bindings with this info too.


thanks,
srini