linux-kernel - Re: [PATCH 11/11] nilfs2: clean trailing semicolons in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 May 2016 23:17:03 +0900 (JST)
From:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
Subject: Re: [PATCH 11/11] nilfs2: clean trailing semicolons in macros

Hi Andrew,

On Fri, 29 Apr 2016 22:15:47 +0900, Ryusuke Konishi wrote:
> Remove trailing semicolons from macros, as suggested by checkpatch.pl.
> 
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
> ---
<snip>
> diff --git a/fs/nilfs2/sysfs.h b/fs/nilfs2/sysfs.h
> index 677e3a1..648cedf 100644
> --- a/fs/nilfs2/sysfs.h
> +++ b/fs/nilfs2/sysfs.h
> @@ -66,7 +66,7 @@ struct nilfs_##name##_attr { \
>  			char *); \
>  	ssize_t (*store)(struct kobject *, struct attribute *, \
>  			 const char *, size_t); \
> -};
> +}
>  
>  NILFS_COMMON_ATTR_STRUCT(feature);
>  
> @@ -77,7 +77,7 @@ struct nilfs_##name##_attr { \
>  			char *); \
>  	ssize_t (*store)(struct nilfs_##name##_attr *, struct the_nilfs *, \
>  			 const char *, size_t); \
> -};
> +}
>  
>  NILFS_DEV_ATTR_STRUCT(dev);
>  NILFS_DEV_ATTR_STRUCT(segments);
> @@ -93,7 +93,7 @@ struct nilfs_##name##_attr { \
>  			char *); \
>  	ssize_t (*store)(struct nilfs_##name##_attr *, struct nilfs_root *, \
>  			 const char *, size_t); \
> -};
> +}
>  
>  NILFS_CP_ATTR_STRUCT(snapshot);
>  

Could you apply the following amendment ?

The above patch didn't modify the same style issue in nilfs2/sysfs.c.
This addition covers the remaining places.

Thanks,
Ryusuke Konishi
--
diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c
index bbb0dcc..3e7d853 100644
--- a/fs/nilfs2/sysfs.c
+++ b/fs/nilfs2/sysfs.c
@@ -68,7 +68,7 @@ static ssize_t nilfs_##name##_attr_store(struct kobject *kobj, \
 static const struct sysfs_ops nilfs_##name##_attr_ops = { \
 	.show	= nilfs_##name##_attr_show, \
 	.store	= nilfs_##name##_attr_store, \
-};
+}
 
 #define NILFS_DEV_INT_GROUP_TYPE(name, parent_name) \
 static void nilfs_##name##_attr_release(struct kobject *kobj) \
@@ -84,7 +84,7 @@ static struct kobj_type nilfs_##name##_ktype = { \
 	.default_attrs	= nilfs_##name##_attrs, \
 	.sysfs_ops	= &nilfs_##name##_attr_ops, \
 	.release	= nilfs_##name##_attr_release, \
-};
+}
 
 #define NILFS_DEV_INT_GROUP_FNS(name, parent_name) \
 static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \
-- 
1.8.3.1