linux-kernel - Re: [PATCH] mfd: vexpress: add !ARCH_USES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 May 2016 15:40:06 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency

On Wed, 27 Apr 2016, Arnd Bergmann wrote:

> The MFD_VEXPRESS_SYSREG driver selects CLKSRC_MMIO, which in turn
> conflicts with ARCH_USES_GETTIMEOFFSET, causing a harmless Kconfig
> warning when it is set:
> 
> warning: (ARCH_MVEBU && ARCH_DIGICOLOR && ARCH_GEMINI && ARCH_KEYSTONE && ARCH_MOXART && ARCH_MXS && PLAT_SPEAR && ARCH_SUNXI && ARCH_TEGRA && ARCH_U300 && PLAT_ORION && ARCH_CLPS711X && ARCH_EP93XX && ARCH_NETX && ARCH_IXP4XX && ARCH_KS8695 && ARCH_W90X900 && ARCH_PXA && ARCH_SA1100 && ARCH_OMAP1 && ARCH_BCM_IPROC && ARCH_INTEGRATOR_AP && ARCH_OMAP2PLUS && MFD_VEXPRESS_SYSREG) selects CLKSRC_MMIO which has unmet direct dependencies (!ARCH_USES_GETTIMEOFFSET)
> 
> This was apparently hidden by the fact that no ARM platform that
> still sets ARCH_USES_GETTIMEOFFSET has gpiolib support, and we
> already have a dependency on GPIOLIB that I added a while ago.
> 
> However, after 296ad4acb8ef ("gpio: remove deps on
> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB"), any platform can enable
> CONFIG_GPIOLIB, and that lets us enable MFD_VEXPRESS_SYSREG
> as well.
> 
> This adds an explicit dependency on !ARCH_USES_GETTIMEOFFSET
> to guarantee that we can enable the CLKSRC_MMIO driver without
> getting warnings.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 4b6d60f65429..461c0c4ff8d8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1569,7 +1569,7 @@ endmenu
>  
>  config MFD_VEXPRESS_SYSREG
>  	bool "Versatile Express System Registers"
> -	depends on VEXPRESS_CONFIG && GPIOLIB
> +	depends on VEXPRESS_CONFIG && GPIOLIB && !ARCH_USES_GETTIMEOFFSET
>  	default y
>  	select CLKSRC_MMIO
>  	select GPIO_GENERIC_PLATFORM

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog