linux-kernel - Re: [PATCH] ARM: dts: at91: sama5d2: use "atmel,sama5d3-nfc" compatible for nfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 May 2016 19:17:54 +0200
From:	Romain Izard <romain.izard.pro@...il.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Wenyou Yang <wenyou.yang@...el.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	David Mosberger <davidm@...uge.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d2: use "atmel,sama5d3-nfc"
 compatible for nfc

2016-05-09 18:34 GMT+02:00 Nicolas Ferre <nicolas.ferre@...el.com>:
> From: Wenyou Yang <wenyou.yang@...el.com>
>
> An error in documentation of the NAND Flash Controller (NFC) led to choose
> another compatibility string for sama5d2 with an impact on the NAND flash
> ready/busy information. It was producing the error message:
>
> atmel_nand 80000000.nand: Time out to wait for interrupt: 0x08000000
>
> and had an impact on performance.
>
> So, switch back to the classical "atmel,sama5d3-nfc" compatibility string for
> this SoC which gives the proper ready/busy bit information. The NAND flash
> driver will be updated to remove the support for this different
> implementation.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> [nicolas.ferre@...el.com: change commit message]
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>

Acked-by: Romain Izard <romain.izard.pro@...il.com>

> ---
> Wenyou, Romain,
>
> I plan to send this patch for 4.6-rc as a fix tomorrow (my time). Can you
> please tell me if it's okay on your side.
> I revised the commit message just to justify the very late "fix" sending of
> this patch...
>
> Thanks for your help, bye.
>   Nicolas.
>
>
>  arch/arm/boot/dts/sama5d2.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 78996bdbd3df..9817090c1b73 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -280,7 +280,7 @@
>                         status = "disabled";
>
>                         nfc@...00000 {
> -                               compatible = "atmel,sama5d4-nfc";
> +                               compatible = "atmel,sama5d3-nfc";
>                                 #address-cells = <1>;
>                                 #size-cells = <1>;
>                                 reg = < /* NFC Command Registers */
> --
> 2.1.3
>