linux-kernel - Re: [PATCH v2] uapi glibc compat: fix compile errors when glibc net/if.h included before linux/if.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160509213535.GA23623@salvia>
Date:	Mon, 9 May 2016 23:35:35 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Josh Boyer <jwboyer@...oraproject.org>
Cc:	Mikko Rapeli <mikko.rapeli@....fi>,
	"David S. Miller" <davem@...emloft.net>,
	Zhang Shengju <zhangshengju@...s.chinamobile.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Jan Engelhardt <jengelh@...i.de>,
	Waldemar Brodkorb <mail@...demar-brodkorb.de>,
	Gabriel Laskar <gabriel@....epita.fr>,
	netfilter-devel@...r.kernel.org,
	libc-alpha <libc-alpha@...rceware.org>
Subject: Re: [PATCH v2] uapi glibc compat: fix compile errors when glibc
 net/if.h included before linux/if.h

On Mon, May 09, 2016 at 09:59:22AM -0400, Josh Boyer wrote:
> On Sun, Apr 24, 2016 at 11:45 AM, Mikko Rapeli <mikko.rapeli@....fi> wrote:
> > glibc's net/if.h contains copies of definitions from linux/if.h and these
> > conflict and cause build failures if both files are included by application
> > source code. Changes in uapi headers, which fixed header file dependencies to
> > include linux/if.h when it was needed, e.g. commit 1ffad83d, made the
> > net/if.h and linux/if.h incompatibilities visible as build failures for
> > userspace applications like iproute2 and xtables-addons.
> >
> > This patch fixes compile errors when glibc net/if.h is included before
> > linux/if.h:
> >
> > ./linux/if.h:99:21: error: redeclaration of enumerator ‘IFF_NOARP’
[...]
> >
> > The cases where linux/if.h is included before net/if.h need a similar fix in
> > the glibc side, or the order of include files can be changed userspace
> > code as a workaround.
> >
> > This change was tested in x86 userspace on Debian unstable with
> > scripts/headers_compile_test.sh:
> >
> > $ make headers_install && \
> >   cd usr/include && ../../scripts/headers_compile_test.sh -l -k
> > ...
> > cc -Wall -c -nostdinc -I /usr/lib/gcc/i586-linux-gnu/5/include -I /usr/lib/gcc/i586-linux-gnu/5/include-fixed -I . -I /home/mcfrisk/src/linux-2.6/usr/headers_compile_test_include.2uX2zH -I /home/mcfrisk/src/linux-2.6/usr/headers_compile_test_include.2uX2zH/i586-linux-gnu -o /dev/null ./linux/if.h_libc_before_kernel.h
> > PASSED libc before kernel test: ./linux/if.h
> >
> > Reported-by: Jan Engelhardt <jengelh@...i.de>
> > Reported-by: Josh Boyer <jwboyer@...oraproject.org>
> > Reported-by: Stephen Hemminger <shemming@...cade.com>
> > Reported-by: Waldemar Brodkorb <mail@...demar-brodkorb.de>
> > Cc: Gabriel Laskar <gabriel@....epita.fr>
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
> 
> Bump.  Did this get lost in a queue somewhere?

It seems linux-netdev was not Cc'ed. I cannot find this in David's
patchwork [1].

@Mikko: Could you resubmit including netdev@...r.kernel.org? Thanks.

[1] http://patchwork.ozlabs.org/project/netdev/list/.