linux-kernel - Re: powerpc: Fix sstep compile on powerpcspe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3r4CYn2j81z9t4h@ozlabs.org>
Date:	Wed, 11 May 2016 07:48:45 +1000 (AEST)
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>,
	linux-kernel@...r.kernel.org
Cc:	Paul Mackerras <paulus@...ba.org>, linuxppc-dev@...ts.ozlabs.org,
	Len Sorensen <lsorense@...lub.uwaterloo.ca>
Subject: Re: powerpc: Fix sstep compile on powerpcspe

On Thu, 2016-05-05 at 20:44:44 UTC, Lennart Sorensen wrote:
> powerpc: Fix sstep compile on powerpcspe
> 
> Commit be96f63375a14ee8e690856ac77e579c75bd0bae introduced ldarx and stdcx
> into the instructions in sstep.c, which are not accepted by the assembler
> on powerpcspe, but does seem to be accepted by the normal powerpc assembler
> even in 32 bit mode.
> 
> Wrap these two instructions in a __powerpc64__ check like it is everywhere
> else in the file.
> 
> Fixes: be96f63375a1 ("powerpc: Split out instruction analysis part of emulate_step()")
> Signed-off-by: Len Sorensen <lsorense@...lub.uwaterloo.ca>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/03be7e53dee606c189a66a7389

cheers