linux-kernel - Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ziry759d.fsf@linux.intel.com>
Date:	Tue, 10 May 2016 10:15:42 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Brian Norris <briannorris@...omium.org>,
	William Wu <william.wu@...k-chips.com>
Cc:	gregkh@...uxfoundation.org, heiko@...ech.de, dianders@...gle.com,
	kever.yang@...k-chips.com, huangtao@...k-chips.com,
	frank.wang@...k-chips.com, eddie.cai@...k-chips.com,
	John.Youn@...opsys.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip


Hi,

Brian Norris <briannorris@...omium.org> writes:
> Hi William,
>
> Did you leave off linux-rockchip@...ts.infradead.org intentionally? IMO,
> it's nice to have that list in CC, so interested parties can follow your
> work, even if they aren't as fortunate as me to have been CC'd on your
> patch directly.
>
> On Mon, May 09, 2016 at 07:46:14PM +0800, William Wu wrote:
>> Signed-off-by: William Wu <william.wu@...k-chips.com>
>> ---
>>  drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>> index 9743353..1f3665b 100644
>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>>  static const struct of_device_id of_dwc3_simple_match[] = {
>>  	{ .compatible = "qcom,dwc3" },
>>  	{ .compatible = "xlnx,zynqmp-dwc3" },
>> +	{ .compatible = "rockchip,dwc3" },
>
> Add to Documentation/devicetree/bindings/. Do we need a new
> Documentation/devicetree/bindings/usb/rockchip,dwc3.txt, to match the
> pattern of qcom and xlnx? Or can we just add to dwc3.txt, since so far,
> all bindings are documented in the common file?

dwc3.txt is for dwc3.ko. We need separate files for rockchip, xilinx and
qualcomn :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)