linux-kernel - Re: [PATCH] memcg: fix stale mem_cgroup_force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160510072837.GC23576@dhcp22.suse.cz>
Date:	Tue, 10 May 2016 09:28:37 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Greg Thelen <gthelen@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Vladimir Davydov <vdavydov@...tuozzo.com>,
	cgroups@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment

On Fri 06-05-16 14:23:30, Greg Thelen wrote:
> commit f61c42a7d911 ("memcg: remove tasks/children test from
> mem_cgroup_force_empty()") removed memory reparenting from the function.
> 
> Fix the function's comment.
> 
> Signed-off-by: Greg Thelen <gthelen@...gle.com>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  mm/memcontrol.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index fe787f5c41bd..19fd76168a05 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2636,8 +2636,7 @@ static inline bool memcg_has_children(struct mem_cgroup *memcg)
>  }
>  
>  /*
> - * Reclaims as many pages from the given memcg as possible and moves
> - * the rest to the parent.
> + * Reclaims as many pages from the given memcg as possible.
>   *
>   * Caller is responsible for holding css reference for memcg.
>   */
> -- 
> 2.8.0.rc3.226.g39d4020

-- 
Michal Hocko
SUSE Labs