linux-kernel - Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 May 2016 10:09:40 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Paul Burton <paul.burton@...tec.com>
Cc:	linux-mips@...ux-mips.org, "Maciej W. Rozycki" <macro@...tec.com>,
	linux-kernel@...r.kernel.org, James Hogan <james.hogan@...tec.com>,
	Markos Chandras <markos.chandras@...tec.com>
Subject: Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation

On Thu, Apr 21, 2016 at 02:04:45PM +0100, Paul Burton wrote:

> The conditions for branching when emulating the BC1EQZ & BC1NEZ
> instructions were backwards, leading to each of those instructions being
> treated as the other. Fix this by reversing the conditions, and clear up
> the code a little for readability & checkpatch.
> 
> Fixes: c909ca718e8f ("MIPS: math-emu: Emulate missing BC1{EQ,NE}Z instructions")
> Signed-off-by: Paul Burton <paul.burton@...tec.com>
> Reviewed-by: James Hogan <james.hogan@...tec.com>

Patch ok - but you may want to take Markos off the cc list.  Or iff he's
still interested, is there any new address for him to use instead?

  Ralf