linux-kernel - Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9651510.pg5Vmm8vKS@wuerfel>
Date:	Tue, 10 May 2016 10:36:40 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	"Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com>,
	Yury Norov <ynorov@...iumnetworks.com>,
	linux-doc@...r.kernel.org,
	Andrew Pinski <Andrew.Pinski@...iumnetworks.com>,
	catalin.marinas@....com, heiko.carstens@...ibm.com,
	Hanjun Guo <guohanjun@...wei.com>, joseph@...esourcery.com,
	linux-arch@...r.kernel.org, linux-s390@...r.kernel.org,
	"jijun (D)" <jijun2@...wei.com>, Prasun.Kapoor@...iumnetworks.com,
	schwab@...e.de, agraf@...e.de, pinskia@...il.com,
	klimov.linux@...il.com, broonie@...nel.org,
	Nathan_Lynch@...tor.com, linux-kernel@...r.kernel.org,
	Andrew Pinski <apinski@...ium.com>, schwidefsky@...ibm.com,
	christoph.muellner@...obroma-systems.com
Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

On Tuesday 10 May 2016 15:42:07 Zhangjian wrote:
> On 2016/5/6 20:37, Yury Norov wrote:
> > On Fri, May 06, 2016 at 08:16:48PM +0800, Zhangjian (Bamvor) wrote:
> >
> > AFAIR, here we don't shift offset, as it's 64-bit both in user-
> > and kernel-space,
> In your ilp32-2.22 branch, you wrapper mmap to mmap2 in which type of
> offset is off_t. And off_t is 32bit in ilp32, correct?
> "sysdeps/unix/sysv/linux/aarch64/ilp32/mmap64.c"
> /* mmap is provided by mmap as they are the same. */
> void *__mmap (void *__addr, size_t __len, int __prot,
>                       int __flags, int __fd, __off_t __offset)
> {
>     void *result;
>     result = (void *)
>       INLINE_SYSCALL (mmap2, 6, __addr,
>                       __len, __prot, __flags, __fd, __offset);
>     return result;
> }

__off_t should be 'long long' on new architectures, and map
to __kernel_loff_t.

Can you see how it is defined?

	Arnd