linux-kernel - Re: [PATH v2] NVMe: init nvme queue before enabling irq

Open Source and information security mailing list archives

Message-ID: <20160510091321.GC22590@c203.arch.suse.de>
Date:	Tue, 10 May 2016 11:13:21 +0200
From:	Johannes Thumshirn <jthmshirn@...e.de>
To:	Jens Axboe <axboe@...com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Wenbo Wang <mail_weber_wang@....com>,
	Wenbo Wang <wenbo.wang@...blaze.com>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	keith.busch@...el.com, wenwei.tao@...blaze.com,
	linux-nvme@...ts.infradead.org
Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq

On Wed, Jan 20, 2016 at 10:17:10AM -0700, Jens Axboe wrote:
> On 01/20/2016 10:12 AM, Greg KH wrote:
> > On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote:
> > > From: Wenbo Wang <wenbo.wang@...blaze.com>
> > > 
> > > During reset process, the nvme_dev->bar (ioremapped) may change,
> > > so nvmeq->q_db shall be also updated by nvme_init_queue().
> > > 
> > > Currently nvmeq irq is enabled before queue init, so a spurious
> > > interrupt triggered nvme_process_cq may access nvmeq->q_db just
> > > before it is updated, this could cause kernel panic.
> > > 
> > > Signed-off-by: Wenbo Wang <wenbo.wang@...blaze.com>
> > > Reviewed-by: Wenwei Tao <wenwei.tao@...blaze.com>
> > > ---
> > >   drivers/nvme/host/pci.c | 14 +++++++++-----
> > >   1 file changed, 9 insertions(+), 5 deletions(-)
> > 
> > <formletter>
> > 
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
> 
> I'll mark it stable when adding, just ignore it for now.
> 
> -- 
> Jens Axboe
> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

Ping?

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives