linux-kernel - Re: [PATCH 0/2] mtd: atmel_nand: remove compatible "atmel,sama5d4-nfc"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160510115258.GS2890@piout.net>
Date:	Tue, 10 May 2016 13:52:58 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
Cc:	Rob Herring <robh@...nel.org>,
	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Brown <broonie@...nel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Russell King <linux@....linux.org.uk>,
	Josh Wu <rainyfeeling@...look.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 0/2] mtd: atmel_nand: remove compatible
 "atmel,sama5d4-nfc"

On 10/05/2016 at 04:50:37 +0000, Yang, Wenyou wrote :
> 
> 
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@...nel.org]
> > Sent: 2016年5月10日 4:13
> > To: Yang, Wenyou <Wenyou.Yang@...el.com>
> > Cc: Brian Norris <computersforpeace@...il.com>; David Woodhouse
> > <dwmw2@...radead.org>; Pawel Moll <pawel.moll@....com>; Mark Brown
> > <broonie@...nel.org>; Ian Campbell <ijc+devicetree@...lion.org.uk>; Kumar
> > Gala <galak@...eaurora.org>; linux-kernel@...r.kernel.org; linux-
> > mtd@...ts.infradead.org; devicetree@...r.kernel.org; Ferre, Nicolas
> > <Nicolas.FERRE@...el.com>; Alexandre Belloni <alexandre.belloni@...e-
> > electrons.com>; Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>;
> > Russell King <linux@....linux.org.uk>; Josh Wu <rainyfeeling@...look.com>;
> > linux-arm-kernel@...ts.infradead.org
> > Subject: Re: [PATCH 0/2] mtd: atmel_nand: remove compatible "atmel,sama5d4-
> > nfc"
> > 
> > On Mon, May 09, 2016 at 02:51:17PM +0800, Wenyou Yang wrote:
> > > It is a datasheet bug, for current SoCs, the RB_EDGE3(i.e. bit 27) of
> > > HSMC_SR register does not exist, the RB_EDGE0 (i.e. bit 24) is the
> > > ready/busy line edge status bit. So the compatible "atmel,sama5d4-nfc"
> > > is unneeded.
> > 
> > The compatible is needed if the SOC still exists. You can list both for the sama5d4
> > if the block is the same.
> 
> The NFC IP of SAMA5D4 is same as SAMA5D2's, SAMA5D4 hase this issue.  This compatible can be removed. 
> 

Well, I agree with Rob, we don't remove an existing compatible. Simply
make it do the right thing (i.e. the same as sama5d3-nfc).

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com