linux-kernel - Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJkX9fs0a_Xcqm6He04_43UBDjVevnYEDrgJ2hBis_g=A@mail.gmail.com>
Date:	Tue, 10 May 2016 09:23:43 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Pantelis Antoniou <panto@...oniou-consulting.com>
Cc:	Frank Rowand <frowand.list@...il.com>,
	Matt Porter <mporter@...sulko.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Koen Kooi <koen@...inion.thruhere.net>,
	Guenter Roeck <linux@...ck-us.net>,
	Marek Vasut <marex@...x.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays.

On Tue, May 10, 2016 at 8:56 AM, Pantelis Antoniou
<panto@...oniou-consulting.com> wrote:
> Hi Rob,
>
>> On May 10, 2016, at 00:47 , Rob Herring <robherring2@...il.com> wrote:
>>
>> On Mon, May 9, 2016 at 1:11 PM, Pantelis Antoniou
>> <pantelis.antoniou@...sulko.com> wrote:
>>> Insert overlay symbols to the base tree when applied.
>>> This makes it possible to apply an overlay that references a label
>>> that a previously inserted overlay had.

[...]

>>> +       /* locate the symbols & fixups nodes on resolve */
>>> +       for_each_child_of_node(tree, child) {
>>> +               if (of_node_cmp(child->name, "__symbols__") == 0)
>>> +                       goto found;
>>
>> Doesn't of_get_child_by_name work here?
>>
>
> No, we’re holding of_mutex.

So. Go look at the function.

Rob