linux-kernel - [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1462891231-17605-1-git-send-email-julien.grall@arm.com>
Date:	Tue, 10 May 2016 15:40:31 +0100
From:	Julien Grall <julien.grall@....com>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	will.deacon@....com, linux-kernel@...r.kernel.org,
	julien.grall@....com, catalin.marinas@....com,
	stable@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
	"Suzuki K. Poulose" <suzuki.poulose@....com>
Subject: [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str

The loop that browses the array compat_hwcap_str will stop when a NULL
is encountered, however NULL is missing at the end of array. This will
result to overrun until one NULL is found somewhere in the memory.

Fixes: 44b82b7700d0 "arm64: Fix up /proc/cpuinfo"
Signed-off-by: Julien Grall <julien.grall@....com>
Cc: stable@...r.kernel.org

---

Cc: Mark Rutland <mark.rutland@....com>
Cc: Suzuki K. Poulose <suzuki.poulose@....com>
---
 arch/arm64/kernel/cpuinfo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
index 84c8684..f0c3fb7 100644
--- a/arch/arm64/kernel/cpuinfo.c
+++ b/arch/arm64/kernel/cpuinfo.c
@@ -87,7 +87,8 @@ static const char *const compat_hwcap_str[] = {
 	"idivt",
 	"vfpd32",
 	"lpae",
-	"evtstrm"
+	"evtstrm",
+	NULL
 };
 
 static const char *const compat_hwcap2_str[] = {
-- 
1.9.1