linux-kernel - [PATCH RFC] ctype: update comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7702210.VDiUoWCC56@kitchen>
Date:	Tue, 10 May 2016 17:43:55 +0300
From:	"Ilya V. Matveychikov" <matvejchikov@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH RFC] ctype: update comments

We have isspace() which may be used incorrectly as one might expect that
it has the same meaning as POSIX isspace(). Also, kernel has outdated
comment about of what is space and hard space exactely.

Signed-off-by: Ilya V. Matveychikov <matvejchikov@...il.com>
---
 include/linux/ctype.h | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/include/linux/ctype.h b/include/linux/ctype.h
index 653589e..5c03748 100644
--- a/include/linux/ctype.h
+++ b/include/linux/ctype.h
@@ -11,9 +11,20 @@
 #define _D	0x04	/* digit */
 #define _C	0x08	/* cntrl */
 #define _P	0x10	/* punct */
-#define _S	0x20	/* white space (space/lf/tab) */
+#define _S	0x20	/* space
+			   0x09 - Horizontal Tab (HT)
+			   0x0A - Line Feed (LF)
+			   0x0B - Vertical Tab (VT)
+			   0x0C - Form Feed (FF)
+			   0x0D - Carriage Return (CR)
+			   0x20 - Space (SP)
+			   0xA0 - Non-Breakable Space (NBSP)
+			*/
 #define _X	0x40	/* hex digit */
-#define _SP	0x80	/* hard space (0x20) */
+#define _SP	0x80	/* hard space
+			   0x20 - Space (SP)
+			   0xA0 - Non-Breakable Space (NBSP)
+			 */
 
 extern const unsigned char _ctype[];
 
-- 
2.8.0