lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 May 2016 16:14:36 +0100 From: Jon Hunter <jonathanh@...dia.com> To: Marc Zyngier <marc.zyngier@....com> CC: Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>, Jon Hunter <jonathanh@...dia.com> Subject: [PATCH 02/11] irqdomain: Warn if we fail to set the IRQ type When setting the IRQ type we don't check the return value to see if it is set correctly. Due to this, failures to set the IRQ type have gone unnoticed and because these failures were not catastrophic have not had an impact on the system. Ideally, we should return an error if we fail to set the type, however, this could cause non-catastrophic failures to prevent devices from working. Therefore, for now add a warning so that any bad interrupt configurations can be corrected. Signed-off-by: Jon Hunter <jonathanh@...dia.com> --- kernel/irq/irqdomain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 8798b6c9e945..09060072cc28 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -610,7 +610,8 @@ unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec) /* Set type if specified and different than the current one */ if (type != IRQ_TYPE_NONE && type != irq_get_trigger_type(virq)) - irq_set_irq_type(virq, type); + if (irq_set_irq_type(virq, type)) + pr_warn("failed to set type for irq %d\n", virq); return virq; } EXPORT_SYMBOL_GPL(irq_create_fwspec_mapping); -- 2.1.4
Powered by blists - more mailing lists