linux-kernel - Re: [GIT PULL] overlayfs fixes for 4.6-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160510152704.GK2694@ZenIV.linux.org.uk>
Date:	Tue, 10 May 2016 16:27:05 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-unionfs@...r.kernel.org
Subject: Re: [GIT PULL] overlayfs fixes for 4.6-rc7

On Tue, May 03, 2016 at 10:04:03PM +0200, Miklos Szeredi wrote:
> Hi Al,
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
> 
> This fixes two issues with overlayfs.
> 
> Thanks,
> Miklos
> 
> ---
> Miklos Szeredi (3):
>       vfs: rename: check backing inode being equal
>       vfs: export lookup_hash() to modules
>       ovl: ignore permissions on underlying lookup

	NAK on lookup_hash().  If nothing else, you need either
lookup_one_len_unlocked() or its "we already know hash" variant (assuming it's
worth bothering with).  That locking the parent is potentially a lot costlier
than recalculating the (default) hash function.  Especially in -next, where
lookup_one_len_unlocked() will take the lock shared if it has to take it at
all, but the mainline one also has a good chance to avoid taking the lock.