linux-kernel - Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160510155637.GG2274@localhost>
Date:	Tue, 10 May 2016 21:26:37 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	Peter Hurley <peter@...leysoftware.com>,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE,
 DMA_CYCLIC

On Wed, May 04, 2016 at 10:29:39PM +0300, Andy Shevchenko wrote:
> When check for capabilities recognize slave support by eother DMA_SLAVE or
							^^^^^^^
typo

> DMA_CYCLIC bit set. If we don't do that the user can't get a normally worked
> DMA support for engines that doesn't have one of the mentioned bits set.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/dma/dmaengine.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index 5ff79a0..59eb4fa 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -482,8 +482,8 @@ int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
>  	device = chan->device;
>  
>  	/* check if the channel supports slave transactions */
> -	if ((!test_bit(DMA_SLAVE, device->cap_mask.bits)) ||
> -			(!test_bit(DMA_CYCLIC, device->cap_mask.bits)))
> +	if (!(test_bit(DMA_SLAVE, device->cap_mask.bits) ||
> +	      test_bit(DMA_CYCLIC, device->cap_mask.bits)))
>  		return -ENXIO;
>  
>  	/*
> -- 
> 2.8.1
> 

-- 
~Vinod