linux-kernel - Re: [PATCH V3 2/4] net-next: mediatek: fix gigabit and flow control advertisement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160510.120003.1015276506691915584.davem@davemloft.net>
Date:	Tue, 10 May 2016 12:00:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	john@...ozen.org
Cc:	nbd@....name, netdev@...r.kernel.org,
	linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 2/4] net-next: mediatek: fix gigabit and flow
 control advertisement

From: John Crispin <john@...ozen.org>
Date: Tue, 10 May 2016 07:08:39 +0200

> @@ -236,7 +247,8 @@ static int mtk_phy_connect(struct mtk_mac *mac)
>  	mac->phy_dev->autoneg = AUTONEG_ENABLE;
>  	mac->phy_dev->speed = 0;
>  	mac->phy_dev->duplex = 0;
> -	mac->phy_dev->supported &= PHY_BASIC_FEATURES;
> +	mac->phy_dev->supported &= PHY_GBIT_FEATURES | SUPPORTED_Pause |
> +				   ~SUPPORTED_Asym_Pause;

All this does is clear SUPPORTED_Asym_Pause.  Putting the other values
there, is therefore, superfluous.

I think you need to rethink through what you expect this expression to
accomplish.

Thanks.