linux-kernel - Re: [PATCH 1/3] Input - soc_button_array: use gpio_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160510163310.GQ23234@mail.corp.redhat.com>
Date:	Tue, 10 May 2016 18:33:10 +0200
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-input@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Bastien Nocera <hadess@...ess.net>,
	Alexandre Courbot <acourbot@...dia.com>,
	Lejun Zhu <lejun.zhu@...ux.intel.com>
Subject: Re: [PATCH 1/3] Input - soc_button_array: use gpio_is_valid()

On May 10 2016 or thereabouts, Fabio Estevam wrote:
> On Tue, May 10, 2016 at 12:37 PM, Benjamin Tissoires
> <benjamin.tissoires@...hat.com> wrote:
> 
> > @@ -92,7 +93,7 @@ soc_button_device_create(struct platform_device *pdev,
> >                         continue;
> >
> >                 gpio = soc_button_lookup_gpio(&pdev->dev, info->acpi_index);
> > -               if (gpio < 0)
> > +               if (gpio_is_valid(gpio))
> 
> Shouldn't it be "if (!gpio_is_valid(gpio))" ?

Oops, indeed. I messed up between the various trees as it's not that
convenient to recompile a full kernel on an atom device. Will fix this
in v2.

Cheers,
Benjamin