lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 May 2016 10:23:54 -0600 From: Toshi Kani <toshi.kani@....com> To: dan.j.williams@...el.com, jack@...e.cz, david@...morbit.com, viro@...iv.linux.org.uk Cc: axboe@...com, hch@...radead.org, boaz@...xistor.com, tytso@....edu, adilger.kernel@...ger.ca, ross.zwisler@...ux.intel.com, toshi.kani@....com, micah.parrish@....com, linux-nvdimm@...ts.01.org, linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH v4 3/6] ext4: Add alignment check for DAX mount When a partition is not aligned by 4KB, mount -o dax succeeds, but any read/write access to the filesystem fails, except for metadata update. Call bdev_dax_supported() to perform proper precondition checks which includes this partition alignment check. Reported-by: Micah Parrish <micah.parrish@....com> Signed-off-by: Toshi Kani <toshi.kani@....com> Reviewed-by: Jan Kara <jack@...e.cz> Cc: "Theodore Ts'o" <tytso@....edu> Cc: Andreas Dilger <adilger.kernel@...ger.ca> Cc: Jan Kara <jack@...e.cz> Cc: Dan Williams <dan.j.williams@...el.com> Cc: Ross Zwisler <ross.zwisler@...ux.intel.com> Cc: Christoph Hellwig <hch@...radead.org> Cc: Boaz Harrosh <boaz@...xistor.com> --- fs/ext4/super.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 304c712..6925e86 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3416,16 +3416,9 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) } if (sbi->s_mount_opt & EXT4_MOUNT_DAX) { - if (blocksize != PAGE_SIZE) { - ext4_msg(sb, KERN_ERR, - "error: unsupported blocksize for dax"); - goto failed_mount; - } - if (!sb->s_bdev->bd_disk->fops->direct_access) { - ext4_msg(sb, KERN_ERR, - "error: device does not support dax"); + err = bdev_dax_supported(sb, blocksize); + if (err) goto failed_mount; - } } if (ext4_has_feature_encrypt(sb) && es->s_encryption_level) {
Powered by blists - more mailing lists