linux-kernel - Re: [PATCH 2/5] ASoC: da7213: Add checking of SRM lock status before enabling DAI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160510182353.GA6019@sirena.org.uk>
Date:	Tue, 10 May 2016 19:23:53 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH 2/5] ASoC: da7213: Add checking of SRM lock status before
 enabling DAI

On Tue, May 10, 2016 at 07:21:43PM +0100, Mark Brown wrote:
> On Tue, May 10, 2016 at 04:11:05PM +0100, Adam Thomson wrote:
> 
> > +		/* Slave mode, if SRM not enabled no need for status checks */
> > +		pll_ctrl = snd_soc_read(codec, DA7213_PLL_CTRL);
> > +		if (!(pll_ctrl & DA7213_PLL_SRM_EN))
> > +			return 0;
> 
> This isn't going to work, the driver has no volatile registers but it
> does have a cache...

Ugh, yes it does - was looking at the wrong driver there.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)