linux-kernel - [PATCH 1/2] x86/PCI: Add pci_bdwep_bar() quirk entry for Broadwell-EP Home Agent 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1462963930-18506-2-git-send-email-prarit@redhat.com>
Date:	Wed, 11 May 2016 06:52:09 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	linux-pci@...r.kernel.org
Cc:	Prarit Bhargava <prarit@...hat.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: [PATCH 1/2] x86/PCI: Add pci_bdwep_bar() quirk entry for Broadwell-EP Home Agent 1

commit b894157145e4 ("x86/PCI: Mark Broadwell-EP Home Agent & PCU as having
non-compliant BARs") marks Home Agent 0 & PCU has having non-compliant
BARs.  The commit is missing device 0x6f60 for Home Agent 1.

The problem with these devices is documented in the Xeon v4 specification
update (but is unfortunately missing this ID):

BDF2
PCI BARs in the Home Agent Will Return Non-Zero Values During Enumeration
Problem:
During system initialization the Operating System may access the standard
PCI BARs (Base Address Registers). Due to this erratum, accesses to the
Home Agent BAR registers (Bus 1; Device 18; Function 0,4; Offsets (0x14-0x24)
will return non-zero values.
Implication:
The operating system may issue a warning. Intel has not observed any
functional failures due to this erratum.
Workaround:
None identified.

Link: http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html
Fixes: b894157145e4 ("x86/PCI: Mark Broadwell-EP Home Agent & PCU as having non-compliant BARs")
Cc: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: x86@...nel.org
Cc: linux-kernel@...r.kernel.org
Cc: Andi Kleen <ak@...ux.intel.com>
Signed-off-by: Prarit Bhargava <prarit@...hat.com>

---
 arch/x86/pci/fixup.c |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
index b7de1929714b..6d8ab876b732 100644
--- a/arch/x86/pci/fixup.c
+++ b/arch/x86/pci/fixup.c
@@ -552,9 +552,18 @@ static void twinhead_reserve_killing_zone(struct pci_dev *dev)
 }
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x27B9, twinhead_reserve_killing_zone);

+/*
+ * Broadwell EP Home Agent BARs erroneously return non-zero values
+ * during enumeration which cause bogus warnings during resource
+ * allocation.
+ *
+ *   See: http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html
+ *   entry BDF2.
+ */
 static void pci_bdwep_bar(struct pci_dev *dev)
 {
 	dev->non_compliant_bars = 1;
 }
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6f60, pci_bdwep_bar);
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6fa0, pci_bdwep_bar);
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6fc0, pci_bdwep_bar);
-- 
1.7.9.3