linux-kernel - Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57331368.9070101@virtuozzo.com>
Date:	Wed, 11 May 2016 14:11:36 +0300
From:	Andrey Ryabinin <aryabinin@...tuozzo.com>
To:	Alexander Potapenko <glider@...gle.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	kasan-dev <kasan-dev@...glegroups.com>,
	Linux Memory Management List <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix

On 05/11/2016 01:18 PM, Alexander Potapenko wrote:
> On Tue, May 10, 2016 at 3:38 PM, Andrey Ryabinin
> <aryabinin@...tuozzo.com> wrote:
>>  * Fix comment styles,
>  yDid you remove the comments from include/linux/kasan.h because they
> were put inconsistently, or was there any other reason?

We usually comment functions near definition, not declarations.
If you like, put comment back. Just place it near definition.

>>  * Get rid of some ifdefs
> Thanks!
>>  * Revert needless functions renames in quarantine patch
> I believe right now the names are somewhat obscure. I agree however
> the change should be done in a separate patch.

Besides that, I didn't like the fact that you made names longer and exceeded
80-char limit in some places.

>>  * Remove needless local_irq_save()/restore() in per_cpu_remove_cache()
> Ack
>>  * Add new 'struct qlist_node' instead of 'void **' types. This makes
>>    code a bit more redable.
> Nice, thank you!
> 
> How do I incorporate your changes? Is it ok if I merge it with the
> next version of my patch and add a "Signed-off-by: Andrey Ryabinin
> <aryabinin@...tuozzo.com>" line to the description?
> 

Ok, but I don't think that this is matters. Andrew will just craft a diff patch
on top of the current code anyways.
Or you can make such diff by yourself and send it, it's easier to review, after all.