linux-kernel - Re: [PATCH perf/core v7 01/21] tools/perf: Fix lsdir to set errno correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160511135939.GC3619@kernel.org>
Date:	Wed, 11 May 2016 10:59:39 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Masami Hiramatsu <mhiramat@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Hemant Kumar <hemant@...ux.vnet.ibm.com>,
	Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>
Subject: Re: [PATCH perf/core v7 01/21] tools/perf: Fix lsdir to set errno
 correctly

Em Wed, May 11, 2016 at 10:51:27PM +0900, Masami Hiramatsu escreveu:
> Fix lsdir() to set correct positive error number (ENOMEM).
> Since "errno" must have a positive error number instead of
> negative number, fix lsdir to set it correctly.

Masami, please try to:

1) Follow existing convention when writing the patch Subject line, when
in doubt: git log tools/perf/util/util.c and check, in this case I
changed it to "perf tools: Fix lsdir to set errno correctly"

2) Add a Fixed line, for this case I used 'git blame' and added:

Fixes: e1ce726e1db2 ("perf tools: Add lsdir() helper to read a directory")

This helps reviewing (now and down the line), because one can go more
quickly check what was the intention in the original patch, to see if it
is really a fix.

In some cases this looks trivial, like in this patch, sometimes its
not...

Thanks,

- Arnaldo
 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> ---
>  tools/perf/util/util.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index 01c9433..eab077a 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -139,7 +139,7 @@ struct strlist *lsdir(const char *name,
>  
>  	list = strlist__new(NULL, NULL);
>  	if (!list) {
> -		errno = -ENOMEM;
> +		errno = ENOMEM;
>  		goto out;
>  	}
>