linux-kernel - Re: [PATCH] perf/x86: fix undefined shift on 32-bit kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160511140843.GG3192@twins.programming.kicks-ass.net>
Date:	Wed, 11 May 2016 16:08:43 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Jim Cromie <jim.cromie@...il.com>,
	Imre Palik <imrep@...zon.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf/x86: fix undefined shift on 32-bit kernels

On Wed, May 11, 2016 at 04:51:51PM +0300, Andrey Ryabinin wrote:
> Jim reported:
> 	UBSAN: Undefined behaviour in arch/x86/events/intel/core.c:3708:12
> 	shift exponent 35 is too large for 32-bit type 'long unsigned int'
> 
> The use of 'unsigned long' type obviously is not correct here, make it
> 'unsigned long long' instead.
> 
> Fixes: 2c33645d366d ("perf/x86: Honor the architectural performance monitoring version")
> Reported-by: Jim Cromie <jim.cromie@...il.com>
> Signed-off-by: Andrey Ryabinin <aryabinin@...tuozzo.com>

Thanks!