lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160511144230.GC1716@katana>
Date:	Wed, 11 May 2016 16:42:31 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Shardar Shariff Md <smohammed@...dia.com>
Cc:	ldewangan@...dia.com, swarren@...dotorg.org,
	thierry.reding@...il.com, gnurou@...il.com,
	linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, jonathanh@...dia.com
Subject: Re: [PATCH v7 2/4] i2c: tegra: calculate timeout for config load
 when needed

On Mon, Apr 25, 2016 at 07:08:37PM +0530, Shardar Shariff Md wrote:
> Instead of calculating timeout for the config load during init,
> calculate it after config load register is written by using
> readx_poll_timeout().

I don't understand this description. You replace the open coded timeout
routine with readx_poll_timeout. But I don't see any calculation moved?

> +		err = readx_poll_timeout(readl, i2c_dev->base +
> +					 tegra_i2c_reg_addr(i2c_dev,
> +					 I2C_CONFIG_LOAD), val, val == 0,
> +					 1000, I2C_CONFIG_LOAD_TIMEOUT);

readl_poll_timeout? And probably assign the address to a variable to
make the above code block more readable.

Thanks,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ